-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Workspace - Default avatar is different in full screen after uploading avatar and removing it #48667
Merged
MariaHCD
merged 1 commit into
Expensify:main
from
FitseTLT:fix-orginalFilename-optimistic-data
Sep 9, 2024
Merged
Fix - Workspace - Default avatar is different in full screen after uploading avatar and removing it #48667
MariaHCD
merged 1 commit into
Expensify:main
from
FitseTLT:fix-orginalFilename-optimistic-data
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer Checklist
Screenshots/VideosAndroid: Nativea1.webmAndroid: mWeb Chromeaw1.webmiOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-09.at.17.46.15.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-09.at.17.44.22.mp4MacOS: Chrome / SafariScreen.Recording.2024-09-09.at.17.42.02.movMacOS: Desktop |
Pujan92
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
MariaHCD
approved these changes
Sep 9, 2024
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
mvtglobally
added
CP Staging
marks PRs that have been CP'd to staging
and removed
CP Staging
marks PRs that have been CP'd to staging
labels
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #47535
PROPOSAL: #47535 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
a.ava.mp4
Android: mWeb Chrome
a.w.ava.mp4
iOS: Native
i.ava.mp4
iOS: mWeb Safari
iw.ava.mp4
MacOS: Chrome / Safari
w.avatar.mp4
MacOS: Desktop
d.ava.mp4